[FFmpeg-cvslog] r28996 - trunk/libswscale/rgb2rgb_template.c

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 01:19:07AM +0100, Michael Niedermayer wrote:
> On Wed, Mar 18, 2009 at 11:11:50PM +0100, reimar wrote:
> > Author: reimar
> > Date: Wed Mar 18 23:11:50 2009
> > New Revision: 28996
> > 
> > Log:
> > Fix libswscale compilation on non-x86, hopefully without breaking MinGW64 again.
> 
> [...]
> > @@ -1628,10 +1634,11 @@ static inline void RENAME(yuvPlanartouyv
> >                                             long lumStride, long chromStride, long dstStride, long vertLumPerChroma)
> >  {
> >      long y;
> > -    const x86_reg chromWidth= width>>1;
> > +    const long chromWidth= width>>1;
> >      for (y=0; y<height; y++)
> >      {
> >  #if HAVE_MMX
> > +        x86_reg cw = chromWidth;
> >  //FIXME handle 2 lines at once (fewer prefetches, reuse some chroma, but very likely memory-limited anyway)
> >          __asm__ volatile(
> >          "xor                %%"REG_a", %%"REG_a"    \n\t"
> 
> are the object files identical on x86 ?
> if not what is the difference in the generated code?
> is it slower?

after a second thought

the correct solution is to
typedef x86_reg to int on non x86 and maybe rename x86_reg to native_reg

what was commited is, to say it diplomatically, non optimal

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090319/3df43587/attachment.pgp>