[FFmpeg-cvslog] r18023 - in trunk/libavformat: Makefile rtp_asf.c rtp_asf.h rtsp.c rtsp.h

[Reimar Döffinger]

On Tue, Mar 17, 2009 at 08:04:01PM +0100, Diego Biurrun wrote:
> On Tue, Mar 17, 2009 at 02:50:15PM -0400, Ronald S. Bultje wrote:
> > 
> > On Tue, Mar 17, 2009 at 2:47 PM, Reimar D?ffinger
> > <Reimar.Doeffinger at gmx.de> wrote:
> > > Not interested in doing the sed-ing, but maybe FF_ASF_GUID would be
> > > better? It's (unfortunately? :-P ) not like Microsoft are the only ones
> > > using GUIDs and the types may differ.
> > 
> > I'll do it then.
> > 
> > Unfortunately, I_REALLY_DISLIKE_UNDERSCORED_CAPITAL_VARIABLES, so is
> > AvAsfGUID or FFAsfGUID (preferrable, since non-public) ok?
> 
> Tastes are malleable, just update yours :)
> 
> Seriously, FF_ASF_GUID is much more readable than FFAsfGUID and all the
> #defines we have follow this style.

Well, it's a typedef, so FFAsfGuid would fit the naming scheme better,
though it is a bit questionable since ASF and GUID are usually written
all-uppercase.
Anyway, feel free to use whatever you want, it can't be worse than a
compile failure on Mingw.