[FFmpeg-cvslog] r17967 - trunk/libavformat/mxfenc.c

[Baptiste Coudurier]

On 3/14/2009 4:04 PM, Reimar D?ffinger wrote:
> On Sat, Mar 14, 2009 at 11:43:29PM +0100, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Sat Mar 14 23:43:28 2009
>> New Revision: 17967
>>
>> Log:
>> do not parse timestamp if bitexact is set, should fix regression tests
> 
> (trying hard to hold my tongue on using localtime in general)
> There is not much sense on using localtime() and then storing that value
> when the time_t value is 0 (which is the default value).
> I am also not sure if users are particularly happy that even when they
> don't want FFmpeg to write a time stamp their time zone setting ends up
> encoded in the file (unless they use bit-exact).
> Or to make it short: I think CODEC_FLAG_BITEXACT is the wrong condition
> (I don't think it is a great idea to misuse it as a
> "we_are_running_regression_tests" flag), s->timestamp would have been
> the right one, but at least it should be checked in addition.

All right, all right. Changed to gmtime and if s->timestamp is not set
it will write 0.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org