[FFmpeg-cvslog] r17909 - trunk/libavformat/rmdec.c

[Michael Niedermayer]

On Mon, Mar 09, 2009 at 03:45:55PM +0100, Michael Niedermayer wrote:
> On Mon, Mar 09, 2009 at 01:46:32PM +0100, rbultje wrote:
> > Author: rbultje
> > Date: Mon Mar  9 13:46:32 2009
> > New Revision: 17909
> > 
> > Log:
> > Replace separate packet parsing for "old_format" .ra files by a call to
> > ff_rm_parse_packet(). See "[PATCH] Make RM demuxer behave better with -an
> > option" thread, which sort-of turned into an aggregate of unrelated rmdec.c
> > cleanups.
> 
> who has reviewed and approved this patch?
> where is kostyas review and ok?
> 
> I wanted a maintainer for rmdec not 2 people who randomly commit unreveiwed
> code and tell each other afterwards that they are on the right track but
> missed something.
> 
> So
> 1. please revert all unrevied changes to rmdec.c
> 2. id like to see you and kostya post patches and have the other review and
>    explicitly ok them before commit!

4 eyes find more issues than 2, its the advantage of having 2 maintainers ;)

[...]]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090309/379eb81c/attachment.pgp>