[FFmpeg-cvslog] r17867 - trunk/libavutil/fifo.c

michael subversion
Sun Mar 8 01:45:46 CET 2009


Author: michael
Date: Sun Mar  8 01:45:45 2009
New Revision: 17867

Log:
Comments to indicate where memory barriers may be needed.

Modified:
   trunk/libavutil/fifo.c

Modified: trunk/libavutil/fifo.c
==============================================================================
--- trunk/libavutil/fifo.c	Sat Mar  7 23:42:09 2009	(r17866)
+++ trunk/libavutil/fifo.c	Sun Mar  8 01:45:45 2009	(r17867)
@@ -91,6 +91,7 @@ int av_fifo_generic_write(AVFifoBuffer *
             memcpy(f->wptr, src, len);
             src = (uint8_t*)src + len;
         }
+// Write memory barrier needed for SMP here in theory
         f->wptr += len;
         if (f->wptr >= f->end)
             f->wptr = f->buffer;
@@ -103,6 +104,7 @@ int av_fifo_generic_write(AVFifoBuffer *
 
 int av_fifo_generic_read(AVFifoBuffer *f, int buf_size, void (*func)(void*, void*, int), void* dest)
 {
+// Read memory barrier needed for SMP here in theory
     do {
         int len = FFMIN(f->end - f->rptr, buf_size);
         if(func) func(dest, f->rptr, len);
@@ -110,6 +112,7 @@ int av_fifo_generic_read(AVFifoBuffer *f
             memcpy(dest, f->rptr, len);
             dest = (uint8_t*)dest + len;
         }
+// memory barrier needed for SMP here in theory
         av_fifo_drain(f, len);
         buf_size -= len;
     } while (buf_size > 0);




More information about the ffmpeg-cvslog mailing list