[FFmpeg-cvslog] r17556 - trunk/configure

Michael Niedermayer michaelni
Tue Mar 3 20:39:47 CET 2009


On Tue, Mar 03, 2009 at 08:09:59PM +0100, Jindrich Makovicka wrote:
> On Thu, 26 Feb 2009 09:07:40 -0500
> "Ronald S. Bultje" <rsbultje at gmail.com> wrote:
> 
> > Hi,
> > 
> > On Tue, Feb 24, 2009 at 10:38 AM, Diego Biurrun <diego at biurrun.de>
> > wrote:
> > > swscale.c and rgb2rgb.c are still GPL because the optimizations have
> > > not been factored out yet, it's just the yuv2rgb stuff that is
> > > purely LGPL now.
> > 
> > There's #if GPL all around the mmx/etc code (I checked rgb2rgb.c and
> > swscale.c) and it compiles fine when CONFIG_GPL=0. I think the
> > original change was fine, right?
> 
> There is still some x86 ASM (non-mmx) code. The following patch should
> be enough to make the result LGPLable. Checked by running the code
> through gcc -E on x86-64. There is no ASM lest except the trivial stuff
> like emms.

patch ok, please apply ASAP

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090303/1b39f0f0/attachment.pgp>



More information about the ffmpeg-cvslog mailing list