[FFmpeg-cvslog] r17776 - trunk/libavformat/rtsp.c

[Reimar Döffinger]

On Tue, Mar 03, 2009 at 05:48:57PM +0100, rbultje wrote:
> Author: rbultje
> Date: Tue Mar  3 17:48:56 2009
> New Revision: 17776
> 
> Log:
> Recognize the "application" data type, which is used at least in ASF/RTP
> streams. However, at the same time, setup of this stream might be required
> for UDP-sessions to work correctly, at the same time it will cause TCP
> sessions to barf. Therefore, add a special case to the TCP code to skip
> setup of these application streams when we are dealing with WMS servers.

I don't know if I understood right, but I think some reordering would do
much good here, e.g.
> Support "application" data type for RTSP, except for TCP connections to
> WMS servers.
> This type is used in ASF/RTP and those streams have to be set up to make
> UDP-sessions work, but doing so would break TCP connections to WMS
> servers.

In my opinion, you should also try to avoid complex words when not
necessary ("However" vs. "but", "Therefore" vs. "Thus", "So"), and while
I too like to do it "work correctly" is not too helpful, so they did
"work incorrectly" before? "will cause ... to barf" is more verbose than
"will break" but not really more helpful?
Please feel free to disregard if you disagree, I just think you write
those messages a lot like good English prose instead of like short
technical descriptions :-) .

> +            /** For WMS streams, the application streams are only used for
> +             * UDP. When trying to set it up for TCP streams, the server
> +             * will return an error. Therefore, we skip those streams. */

No point in using doxygen-style comments in comments in the middle of
the code btw.