[FFmpeg-cvslog] r19234 - trunk/libavcodec/wma.c

[Ivan Kalvachev]

On 6/20/09, Sascha Sommer <saschasommer at freenet.de> wrote:
> Hi,
>
> On Samstag, 20. Juni 2009, Ivan Kalvachev wrote:
>> On 6/20/09, faust3 <subversion at mplayerhq.hu> wrote:
>> > Author: faust3
>> > Date: Sat Jun 20 13:06:48 2009
>> > New Revision: 19234
>> >
>> > Log:
>> > Simplify run level decoding:
>> > - remove unneeded vlc code < 0 check
>>
>> Hum, would you explain this a little bit more.
>> Afaik -1 is returned when sequence that doesn't belong
>> to any known vlc is met.
>> This usually happens on broken streams.
>>
>> Can you prove that wma vlc don't have invalid sequences?
>>
>
> In libavcodec/bitstream.c build_table() the table for get_vlc2 is built
> with unused codes set to -1
>
>     for(i=0;i<table_size;i++) {
>         table[i][1] = 0; //bits
>         table[i][0] = -1; //codes
>     }
>
> After the tables are filled none of the table entries are -1 anymore.

OK, if you have checked all tables.
I still would like at least a comment in the code explaining this.

BTW, why all code comments are in doxygen style? /** */?