[FFmpeg-cvslog] r29354 - trunk/libswscale/swscale-example.c

Måns Rullgård mans
Fri Jun 12 03:06:41 CEST 2009


Ramiro Polla <ramiro.polla at gmail.com> writes:

> revert_declare_aligned_to_internal.diff moves it back from internal.h
> to mem.h, and splits
> -#elif HAVE_INLINE_ASM
> -    #error The asm code needs alignment, but we do not know how to do
> it for this compiler.
> -#else
> into
> +#elif defined(HAVE_AV_CONFIG_H)
> +#if HAVE_INLINE_ASM
> +    #error The asm code needs alignment, but we do not know how to do
> it for this compiler.
> +#endif
> +#else

This is ugly.  Just drop the #error case if it's so important to have
these macros in a public header.

For the record, the stuff in libavutil/internal.h is intended to be
used everywhere in FFmpeg.  All that used to be scattered about
common.h under separate #ifdef HAVE_AV_CONFIG_H.  We moved it to a
separate file to clean things up a bit.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list