[FFmpeg-cvslog] r19142 - trunk/libavformat/rtp_mpv.c

[Luca Abeni]

Hi Luca,

Luca Barbato wrote:
> Luca Abeni wrote:
>>> otherwise ff_find_start_code could read over the buffer size
>> Are you sure about this?
> 
> Hmm, I checked that in after I found a bug in feng's mpv parser (in that
> case size wasn't decremented)
> 
>> Because, buf1 and size are updated like this:
>>         buf1 += len;
>>         size -= len;
>> so, buf1 + size should stay constant...
> 
> Right, in feng it was an actual bug, in ffmpeg it was just an add that
> now is factored out. Maybe I should edit/amend the comment
No problem. The code is now easier to read (thanks!) and the comment is
not really an issue.
I was just concerned about some possible residual bug which was not fixed
by this commit.



				Thanks,
					Luca

P.S.: BTW, why don't you use libavformat's RTP muxer in feng? This would
reduce duplicated code between the two projects, and would probably help
improving the quality of both...