[FFmpeg-cvslog] r19091 - trunk/libavcodec/4xm.c

[Baptiste Coudurier]

On 6/5/2009 2:15 PM, Michael Niedermayer wrote:
> bavcOn Fri, Jun 05, 2009 at 02:12:58PM -0700, Baptiste Coudurier wrote:
>> On 6/5/2009 1:10 PM, Michael Niedermayer wrote:
>>> On Fri, Jun 05, 2009 at 10:12:14AM +0200, bcoudurier wrote:
>>>> Author: bcoudurier
>>>> Date: Fri Jun  5 10:12:14 2009
>>>> New Revision: 19091
>>>>
>>>> Log:
>>>> 4xm decoder uses get_buffer, set CODEC_CAP_DR1
>>> [...]
>>>
>>> one case (that applies to 4xm IIRC) is that linesize == width*bpp is required
>>> by some decoders
>> Can/Should this be set in avcodec_align_dimensions ?
> 
> maybe
> 
> but it doesnt solve the DR1 issue, there is no requirement for a user written
> get_buffer() not to provide more alignment/linesize than
> avcodec_align_dimensions() wants

How can this be solved in an elegant manner ?
The more codecs user can use with get_buffer, the best it is IMHO.

I don't see anything specific to CODEC_ID_4XM in
avcodec_default_get_buffer, but considering the complexity of it, I'm
wondering how can users reasonably implement it correctly.

Considering major decoders are using it (MPEG-2, H264, VC1), I think we
should seriously think about documenting and simplifying it. I'm willing
to work on this.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org