[FFmpeg-cvslog] r19375 - in trunk: Changelog libavcodec/Makefile libavcodec/aac.h libavcodec/aaccoder.c libavcodec/aacenc.c libavcodec/aacenc.h libavcodec/aacpsy.c libavcodec/allcodecs.c libavcodec/psymodel.c liba...

[Reimar Döffinger]

On Fri, Jul 10, 2009 at 05:16:57PM -0400, Alex Converse wrote:
> On Thu, Jul 9, 2009 at 4:24 AM, Reimar
> D?ffinger<Reimar.Doeffinger at gmx.de> wrote:
> > On Wed, Jul 08, 2009 at 10:01:31PM +0200, alexc wrote:
> >> Author: alexc
> >> Date: Wed Jul ?8 22:01:31 2009
> >> New Revision: 19375
> >>
> >> Log:
> >> Merge the AAC encoder from SoC svn. It is still considered experimental.
> >
> > You broke a good deal of FATE configurations. In particular, complex
> > types do not seem to be generally working.
> 
> I believe everything is now fixed. I will check FATE in a little while
> to verify.
> 
> Thank you for your patience. I do not have direct access to some of
> the more esoteric configurations in FATE.

IMO it is acceptable to break them temporarily. Particularly when it is
because they are not C99/POSIX-compliant.
Anyway, thanks for your effort (personally I think I may have preferred
to just disable the encoder where necessary instead of avoiding using
complex, but that definitely is your decision, and I admit this way is
better for future AAC regression tests).