[FFmpeg-cvslog] r16823 - trunk/libavcodec/arm/dsputil_arm_s.S

[Diego Biurrun]

On Wed, Jan 28, 2009 at 10:43:33AM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> 
> > On Tue, Jan 27, 2009 at 05:25:23PM +0000, M?ns Rullg?rd wrote:
> >> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> >> > On Tue, Jan 27, 2009 at 05:06:51PM +0100, mru wrote:
> >> >> 
> >> >> Log:
> >> >> ARM: reorder some instructions in put_pixels*_arm
> >> >
> >> > I think a log message is supposed to contain the why (faster, more
> >> > readable, ...?)
> >> 
> >> Such changes are always for speed.
> >
> > That is a very broad statement, I am sure that someone somewhere has
> > modified some assembler code for some other reason.
> > And I did think that there was consensus that commit messages should
> > provide information beyond what the diff tells, this one definitely
> > doesn't, it hardly qualifies even as a summary since it is not much
> > shorter than the diff.
> 
> And since when do YOU care the slightest about commit messages?  You
> are usually among the most vigorous protesters when asked to write
> descriptive messages.  So shut up already.

Geez, calm down and add a handful of words to that message please.

The request is genuine and well-meaning.  I agree that some extra
information would be helpful.  I myself suspected that it was a speed
optimization, but I was not 100% sure.

Diego