[FFmpeg-cvslog] r16746 - trunk/libavcodec/rectangle.h

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Jan 24, 2009 at 02:51:22PM +0000, M?ns Rullg?rd wrote:
>> diego <subversion at mplayerhq.hu> writes:
>> 
>> > Log:
>> > Add required headers to fix 'make checkheaders'.
>> >
>> > --- trunk/libavcodec/rectangle.h	Sat Jan 24 15:32:22 2009	(r16745)
>> > +++ trunk/libavcodec/rectangle.h	Sat Jan 24 15:46:00 2009	(r16746)
>> > @@ -28,7 +28,10 @@
>> >  #ifndef AVCODEC_RECTANGLE_H
>> >  #define AVCODEC_RECTANGLE_H
>> >
>> > +#include <assert.h>
>> 
>> Be careful with adding assert.h.  You just enabled assert() checking
>> unconditionally in that file and anything that includes it.  Before
>> this commit, assert.h was included through internal.h, which sets
>> NDEBUG before including it.
>
> What is the proper solution then?  Adding #define NDEBUG or #including
> internal.h instead?

I don't know.  Michael refused to talk about it last time I brought it
up.

-- 
M?ns Rullg?rd
mans at mansr.com