[FFmpeg-cvslog] r16717 - trunk/ffmpeg.c

[Baptiste Coudurier]

Hi Michael,

Michael Niedermayer wrote:
> On Thu, Jan 22, 2009 at 01:04:01PM +0100, michael wrote:
>> Author: michael
>> Date: Thu Jan 22 13:04:01 2009
>> New Revision: 16717
>>
>> Log:
>> Handle av_read_frame() EAGAIN return.
> 
> This seems to break the ffm regression test as ffmdec.c returns EAGAIN at
> EOF which causes an infinite loop ...
> Iam not sure how to fix this, ideas are welcome!

Yes it seems design needs to be changed:
Add a new flag FLAG_EOF, and write a ffm packet with it in
ffm_write_trailer, then return -1 when this packet is read.

Btw, what is the practical interest of return EAGAIN instead of
continuing like flv previously did ?

greping EAGAIN in libavformat returns nothing related to demuxers

Also it's been some time Im thinking of adding EOS and EOF return values
instead of return -1 (an error). What do you think about that ?

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org