[FFmpeg-cvslog] r17549 - trunk/libavcodec/pixdesc.h

[Baptiste Coudurier]

On 2/23/2009 5:38 PM, Michael Niedermayer wrote:
> On Mon, Feb 23, 2009 at 05:21:24PM -0800, Baptiste Coudurier wrote:
>> Hi Michael,
>>
>> On 2/23/2009 5:12 PM, michael wrote:
>>> Author: michael
>>> Date: Tue Feb 24 02:12:25 2009
>>> New Revision: 17549
>>>
>>> Log:
>>> AVPixFmtDescriptor doxy
>>>
>>> Modified:
>>>    trunk/libavcodec/pixdesc.h
>>>
>>> Modified: trunk/libavcodec/pixdesc.h
>>> ==============================================================================
>>> --- trunk/libavcodec/pixdesc.h	Tue Feb 24 02:08:29 2009	(r17548)
>>> +++ trunk/libavcodec/pixdesc.h	Tue Feb 24 02:12:25 2009	(r17549)
>>> @@ -31,6 +31,14 @@ typedef struct AVComponentDescriptor{
>>>      uint16_t depth_minus1 :4;            ///< number of bits in the component minus 1
>>>  }AVComponentDescriptor;
>>>  
>>> +/**
>>> + * Descriptor that unambigously describes how the bits of a pixel are
>>> + * stored in the up to 4 data planes of an image. It also stores the
>>> + * subsampling factors and number of components.
>>> + *
>>> + * @note This is seperate of the colorspace (RGB, YCbCr, YPbPr, jpeg style YUV and all the YUV variants)
>>> + *       AVPixFmtDescripto just stores how values are stored not what these values represent.
>>> + */
>> This is very cool, thanks a lot.
>>
>> Quick question, should we adapt:
>>
>> #define SWS_CS_ITU709         1
>> #define SWS_CS_FCC            4
>> #define SWS_CS_ITU601         5
>> #define SWS_CS_ITU624         5
>> #define SWS_CS_SMPTE170M      5
>> #define SWS_CS_SMPTE240M      7
>> #define SWS_CS_DEFAULT        5
>>
>> And define it along in pixdesc.h ?
> 
> iam in favor of adding an enum with the above values
> maybe AVColorspace?

Yes, sounds good.

> to some header

Up to you, but it would be nice to have AVPixelFormat, stuff in
pixdesc.h and AVColorSpace, not too far IMHO.

> and add a colorspace field to AVCodecContext

Sounds good too.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org