[FFmpeg-cvslog] r17383 - trunk/libavcodec/xvmc.h

[Diego Biurrun]

On Mon, Feb 16, 2009 at 07:16:26PM +0100, iive wrote:
> 
> Log:
> Improvements in xvmc structure fields descriptions.
> 
> --- trunk/libavcodec/xvmc.h	Mon Feb 16 17:33:00 2009	(r17382)
> +++ trunk/libavcodec/xvmc.h	Mon Feb 16 19:16:23 2009	(r17383)
> @@ -89,12 +86,12 @@ struct xvmc_pix_fmt {
>      int             unsigned_intra;
>  
>      /** Pointer to the surface allocated by XvMCCreateSurface().
> +        It have to be freed by XvMCDestroySurface() on application exit.

"It has"

I think this is your most common grammar error and it should be
comparatively simple to get rid of.  It's low-hanging if you want to
improve your English...

> @@ -134,19 +130,23 @@ struct xvmc_pix_fmt {
>  
> -    /** Offset to the next free data block. The mv_blocks field holds a number
> -        pointing to the data blocks.
> -        - application - zeroes it on get_buffer() and after successful
> -                        ff_draw_horiz_band().
> -        - libavcodec  - each macroblock increases it with the number
> +    /** Number of the the next free data block.
> +        One data block is 64 short values in data_blocks array.
> +        All blocks before this one are already claimed by filling their number
> +        in the corresponding blocks description structure field,
> +        that are hold in mv_blocks array.

The last sentence is very confusing.  The following improves its grammar
but my tired mind still cannot wrap itself around it:

  All blocks before this one are already claimed by filling their number
  into the corresponding blocks description structure field,
  that are held in the mv_blocks array.

Ivan, could you try to explain this in another handful of words?

Diego