[FFmpeg-cvslog] r17345 - trunk/libavcodec/xvmc.h

[Michael Niedermayer]

On Sun, Feb 15, 2009 at 11:32:15PM +0200, Ivan Kalvachev wrote:
> On 2/15/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Feb 15, 2009 at 09:13:00PM +0100, iive wrote:
> >> Author: iive
> >> Date: Sun Feb 15 21:13:00 2009
> >> New Revision: 17345
> >>
> >> Log:
> >> Describe all fields in xvmc struct.
> >
> > [...]
> >> +    /** Pointer to the block array allocated by XvMCCreateBlocks()
> >> +        it contins differential pixel data (in MoCo mode)
> >> +        or coefficients for IDCT.
> >> +        - application - set during initialization
> >> +        - libavcodec  - unchanged
> >> +    */
> >>      short*          data_blocks;
> >
> > there are 2 things here
> > the pointer and the data it points to
[...]
> >> -    int             idct;                         ///< indicate that IDCT
> >> acceleration level is used
> >> -    int             unsigned_intra;               ///< +-128 for intra
> >> pictures after clipping
> >> -    XvMCSurface*    p_surface;                    ///< pointer to
> >> rendered surface, never changed
> >> +
> >> +    /** Indicates that the hardware would interpret data_blocks as IDCT
> >> cefficients
> >> +        and perform IDCT on them.
> >> +        - application - set during initialization
> >> +        - libavcodec  - unchanged
> >> +    */
> >> +    int             idct;
> >
> > if this is set by the app, why are there 2 PIX_FMT_XVMC_MPEG2 ?
> 
> Because the pix_fmt are passed to the application and it chooses
> whenever to pick surface with and without it.
> 
> Hum, I feel what you want to say.

redundant?


[...]
> >> +
> >> +    /**XVMC_SECOND_FIELD - 1st or 2nd field in the sequence
> >> +        - application - unchanged
> >> +        - libavcodec  - set
> >> +    */
> >> +    unsigned int    flags;
> >
> > picture_structure & top_field_first is not enough?
> 
> It's the opposite of s->first_field .
> 
> > anyway this is pretty good alraedy
> > so +6 (from the remainig 8 for user vs. lavc clarifications)
> 
> What is left?

arrays wher you havnt documented what allocates/frees/sets the actual content
it says application now but only the decoder can set the content ...


> 
> > diego 16
> > ivan 19.5
> >
> > PS: its time you break compile again ;)
> 
> How, If I say I won't be committing code until Diego catches up
> you are probably going to find something to penalize me and
> force me to catch up.
> 

> >From Monday I won't be having so much free time.

thats sad


> I may even let Diego win.

came on, you have come that far, you cant give up now :)
besides i need someone to maintain xvmc

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090216/2e20245b/attachment.pgp>