[FFmpeg-cvslog] r17345 - trunk/libavcodec/xvmc.h

[Ivan Kalvachev]

On 2/15/09, Diego Biurrun <diego at biurrun.de> wrote:
> On Sun, Feb 15, 2009 at 09:13:00PM +0100, iive wrote:
>>
>> Log:
>> Describe all fields in xvmc struct.
>>
>> --- trunk/libavcodec/xvmc.h	Sun Feb 15 20:10:16 2009	(r17344)
>> +++ trunk/libavcodec/xvmc.h	Sun Feb 15 21:13:00 2009	(r17345)
>> @@ -38,28 +38,92 @@ struct xvmc_pix_fmt {
>> +    /** The field contains special constant value.
>> +        It is used as test whenever the application knows the calling
>> API,
>> +        and that there is no corruption caused by pixel routines.
>
> I keep scratching my head when I read this.  How is the calling API
> related to this?

The api using this struct.

>> +    /** Pointer to the block array allocated by XvMCCreateBlocks()
>> +        it contins differential pixel data (in MoCo mode)
>> +        or coefficients for IDCT.
>> +
>> +    /** In MoCo mode it indicates that Intra MB are assumed to be in
>> unsigned format
>> +        Same as XVMC_INTRA_UNSIGNED flag.
>
> I assume MoCo mode is motion compensation mode.  Is there a special reason
> not to simply call it motion compensation?

It is too long and also could be very confusing as motion compensation
is also performed in idct mode.
MoCo is the short name used in the standard definitions. So everybody who
have read it should know it.

>> +    /** Pointer to the Surface allocated by XvMCCreateSurface().
>
> Is "Surface" capitalized on purpose?

Not really, other than differentiate it from casual surface.