[FFmpeg-cvslog] r17297 - trunk/libavcodec/xvmc.h

[Diego Biurrun]

On Sun, Feb 15, 2009 at 12:56:30AM +0100, Diego Biurrun wrote:
> On Sun, Feb 15, 2009 at 01:50:57AM +0200, Ivan Kalvachev wrote:
> > On 2/15/09, Diego Biurrun <diego at biurrun.de> wrote:
> > > On Sun, Feb 15, 2009 at 12:28:09AM +0100, iive wrote:
> > >>
> > >> Log:
> > >> Depricate some unused xvmc structure fields.
> > >>
> > >> --- trunk/libavcodec/xvmc.h	Sun Feb 15 00:13:32 2009	(r17296)
> > >> +++ trunk/libavcodec/xvmc.h	Sun Feb 15 00:28:09 2009	(r17297)
> > >> @@ -38,9 +38,13 @@ struct xvmc_render_state {
> > >>      int             idct;                         ///< indicate that IDCT
> > >> acceleration level is used
> > >> +#if LIBAVCODEC_VERSION_MAJOR < 53
> > >>      int             chroma_format;                ///<
> > >> XVMC_CHROMA_FORMAT_420/422/444
> > >> +#endif
> > >
> > > History repeats itself.  Same as your commit earlier today, this is
> > > missing an avcodec.h #include, which is absolutely necessary in this
> > > installed header.
> > 
> > It compiles for me.
> 
> Sure it compiles, but it's buggy nonetheless. The compiler assumes
> undefined definitions to be 0 and thus the condition is always true
> and will not trigger on the next version bump.

Time for some sportsmanlike conduct ;)

'make checkheaders' or 'make libavcodec/xvmc.ho' will catch such
mistakes.  Maybe you will now better like that feature.

Diego