[FFmpeg-cvslog] r17338 - in trunk/libavcodec: mpegvideo_xvmc.c xvmc.h

Michael Niedermayer michaelni
Sun Feb 15 20:57:49 CET 2009


On Sun, Feb 15, 2009 at 08:19:56PM +0200, Ivan Kalvachev wrote:
> On 2/15/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Feb 15, 2009 at 06:21:38PM +0100, iive wrote:
> >> Author: iive
> >> Date: Sun Feb 15 18:21:37 2009
> >> New Revision: 17338
> >>
> >> Log:
> >> Kill the magic
> >> field in xvmc structure.
> >>
> >> Modified:
> >>    trunk/libavcodec/mpegvideo_xvmc.c
> >>    trunk/libavcodec/xvmc.h
> >>
> >> Modified: trunk/libavcodec/mpegvideo_xvmc.c
> >> ==============================================================================
> >> --- trunk/libavcodec/mpegvideo_xvmc.c	Sun Feb 15 17:54:02 2009	(r17337)
> >> +++ trunk/libavcodec/mpegvideo_xvmc.c	Sun Feb 15 18:21:37 2009	(r17338)
> >> @@ -38,7 +38,7 @@
> >>  void ff_xvmc_init_block(MpegEncContext *s)
> >>  {
> >>      struct xvmc_pixfmt_render *render = (struct
> >> xvmc_pixfmt_render*)s->current_picture.data[2];
> >> -    assert(render && render->magic_id == AV_XVMC_RENDER_MAGIC);
> >> +    assert(render && render->unique_id == AV_XVMC_RENDER_MAGIC);
> >
> > i think xvmc_id is a better name,there is nothing unique on it
> 
> You should have said that in the initial review,
> not play the "guess what I think" game.

i had no specific name in mind just a sane one, unique and magic are not
IMHO

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090215/d4d886c7/attachment.pgp>



More information about the ffmpeg-cvslog mailing list