[FFmpeg-cvslog] r17168 - in trunk/libavcodec: vdpau.c vdpau.h vdpau_pixfmt.h xvmc.c xvmc_pixfmt.h xvmc_render.h

[Diego Biurrun]

On Thu, Feb 12, 2009 at 11:54:14PM +0100, Aurelien Jacobs wrote:
> Diego Biurrun wrote:
> 
> > On Thu, Feb 12, 2009 at 02:09:02AM +0100, Aurelien Jacobs wrote:
> > > diego wrote:
> > > 
> > > > Log:
> > > > Rename [...] and vdpau.h --> vdpau_pixfmt.h
> > > 
> > > This is broken. Make install won't work anymore.
> > > Moreover, strictly speaking, you are breaking public API, and
> > > thus this would require a major version bump.
> > 
> > Hmmm....
> 
> This don't really tells me much...
> 
> Anyway, the situation is quite clear:
>  - either you consider this header part of public API, and then
>    you can't rename it without a major version bump
>  - or you don't consider it part of public API, and then it
>    must not be installed
> I can't see any other possibility.

I do consider it part of the public API, how else are people supposed
to use vdpau/xvmc right now?  When the patch was approved, the header
was installed on purpose for this very reason.

So all in all it's clearly my bad, I'll rename it back later today.

> > > But anyway, it seems that vdpau*.h should really not be part
> > > of public API anyway, so better stop installing it right now.
> > 
> > How else are applications supposed to use vdpau with FFmpeg then?
> 
> The same way they access VA-API or xvmc. Through a common API.
> See the many recent post discussing implementation of HWAccel on
> ffmpeg-devel.
> The following thread, among others, contains various interesting
> ideas:
> [FFmpeg-devel] [PATCH][7/8] Add VA API accelerated H.264 decoding
> 
> Anyway, it should be quite clear to anyone reading ffmpeg-devel
> that hardware acceleration through ffmpeg is currently a moving
> target, and the API to use it is bound to change quite a lot
> before it stabilize. So exporting anything to the outside world
> right now seems pretty much useless.

Maybe, but we have already done it and the new API will not make it
in time for the release.  Also, xvmc has been used that way (with
hacks like using non-public headers) for years.

Diego