[FFmpeg-cvslog] r28500 - trunk/libswscale/swscale-example.c

[Michael Niedermayer]

On Mon, Feb 09, 2009 at 09:00:02PM +0100, Diego Biurrun wrote:
> On Mon, Feb 09, 2009 at 08:53:27PM +0100, Michael Niedermayer wrote:
> > On Mon, Feb 09, 2009 at 07:04:19PM +0100, diego wrote:
> > > 
> > > Log:
> > > Add config.h #include for ARCH_X86 definition.
> > 
> > config.h is not a public header there is no way how swscale-example could
> > include it.
> > Please keep in mind this is a example on how people should use swscale from
> > their code, you wouldnt want them to include our config.h would you?
> 
> Unfortunately this example program was broken in multiple ways.  I fixed
> compilation so that at least 'make tests' can run, but yes, it still has
> issues.  It contains
> 
>   #if ARCH_X86
> 
> which implicitly relies on config.h being available.  Otherwise this
> becomes an '#if 0' in all cases.

Please add a comment that makes it clear that #including config.h is not
acceptable for applications

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090209/b0f4c8fa/attachment.pgp>