[FFmpeg-cvslog] r17068 - in trunk/libavformat: audiointerleave.c audiointerleave.h

[Diego Biurrun]

On Sun, Feb 08, 2009 at 11:59:19PM +0100, Diego Biurrun wrote:
> On Sun, Feb 08, 2009 at 10:09:50PM +0100, bcoudurier wrote:
> > 
> > Log:
> > add static, function unused outside
> 
> How about something like
> 
>   Declare ff_interleave_new_audio_packet as static, it is not used
>   outside of audiointerleave.c.  Also remove the function declaration
>   from the header as it is now static.

Note that this could be shortened to

  Declare ff_interleave_new_audio_packet static, it is not used
  outside of audiointerleave.c.

It's basically just a single word that is added and it makes the log
message infinitely more useful IMO.  This is not about requesting
you to invest huge amounts of time.  Very little extra effort can
make for a huge improvement.

Diego