[FFmpeg-cvslog] r17068 - in trunk/libavformat: audiointerleave.c audiointerleave.h

Reimar Döffinger Reimar.Doeffinger
Mon Feb 9 09:57:28 CET 2009


On Sun, Feb 08, 2009 at 04:54:50PM -0800, Baptiste Coudurier wrote:
> if you are talking about the "list", then you get the full mail, so this
> your comment is irrelevant, you get all the information.

You missed the point. Reading one line vs. reading 20 lines or more of
diff is a difference in effort. Thus I think you should have a strong
argument why it is _better_ not to mention the function name in the
commit message.

> Besides, your concern is only about files you care about, and you get it
> in the commit mail. A commit is comprised of a message, a diff, files it
> modifies, removes or adds.

No, not necessarily. Files I do not usually care about might contain
functions interesting to me, and if they are public or not does concern
me (not to mention commits to such catch-all files as utils.c).

> Now if your tools do not mention this information, IMHO tools need to be
> enhanced. I personally can only barely work without the -cvslog ml, and
> I guess others cannot really either.

Again, this is not about tools, this is about including a single word
that would make it possible for everyone to know quite precisely what
the patch does without looking at the diff (which as said is extra
effort).
I do not like Diego's suggestion that much because it seems too verbose
and I end up reading information I do not care about.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-cvslog mailing list