[FFmpeg-cvslog] r16966 - trunk/libavformat/aiff.c

[Aurelien Jacobs]

On Tue, 3 Feb 2009 01:43:03 +0100
Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> On Tue, Feb 03, 2009 at 01:24:41AM +0100, Aurelien Jacobs wrote:
> > Baptiste Coudurier wrote:
> > > What if I want to write my lyrics in there ? :>
> > 
> > Then you would probably need a bit more than 1024 bytes...
> > If you think it's useful, I will av_malloc() the buffer,
> > but I still need to set some limit. Would a 1MB limit
> > be reasonable enough ?
> 
> Why do you need a limit? Check if the malloc failed.

malloc don't fail on Linux (unless you sysctl -w vm.overcommit_memory=2).
And allowing crafted files to OOM kill ffmpeg (after a long and slow
swapping process) is not nice...

Aurel