[FFmpeg-cvslog] r20839 - trunk/libavformat/id3v2.c

[Jai Menon]

On Mon, Dec 14, 2009 at 12:23:39PM +0100, Michael Niedermayer wrote:
> On Mon, Dec 14, 2009 at 07:54:49AM +0100, Reimar D?ffinger wrote:
> > On Mon, Dec 14, 2009 at 02:53:48AM +0100, Michael Niedermayer wrote:
> > > whats left currently is: (note i manually edited the diff so i cant gurantee
> > > that the stat is completely correctly, iam not sure how good diffstat is at
> > > manually edited diffs)
> > 
> > Can you just dump that diff somewhere? I think the gxf and s302m stuff is "mine",
> > though I expect I might lack samples for them.
> 
> attached, but keep in mind these are my work in progress diffs they are
> hand edited with hunks and lines removed that where merged or that i
> considered not worth the work merging (too much work / bikeshed / things
> appearing incomplete or buggy). Its possible i also removed changes by
> mistake from them!

[...]

> +/**
> + * Used attributes: "language", "mime"
> + */
> +typedef struct {
> +    char *key;
> +    char *value;
> +} AVMetadataAttribute;
> +
> +typedef struct {
> +    unsigned count;
> +    AVMetadataAttribute *elems;
> +} AVMetadataAttributes;
> +
> +enum AVMetadataType {
> +    METADATA_STRING, ///< UTF-8
> +    METADATA_INT,
> +    METADATA_DOUBLE,
> +    METADATA_BYTEARRAY,
> +};

BTW, is there any possibility of the above metadata type being
considered? I'm asking this with reference to cover art export.

(sorry to bring this up again, but since you are merging stuff from
ffmbc, I thought there might be a possibility ;) )

--
Jai Menon