[FFmpeg-cvslog] r20435 - trunk/ffmpeg.c

[Ramiro Polla]

On Tue, Nov 3, 2009 at 9:38 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Monday 2009-11-02 22:53:47 -0200, Ramiro Polla wrote:
>> Hi,
>>
>> On Mon, Nov 2, 2009 at 10:24 PM, Stefano Sabatini
>> <stefano.sabatini-lala at poste.it> wrote:
>> > On date Tuesday 2009-11-03 00:41:54 +0100, ramiro wrote:
>> >> Author: ramiro
>> >> Date: Tue Nov ?3 00:41:54 2009
>> >> New Revision: 20435
>> >>
>> >> Log:
>> >> Add -fpre option to take a preset file as parameter. The -[avs]pre options no
>> >> longer accept filenames, and -fpre should be used instead.
>> >
>> > Please update docs.
>>
>> $attached, please review.
>>
>> Ramiro Polla
>
>> Index: ffmpeg-doc.texi
>> ===================================================================
>> --- ffmpeg-doc.texi ? (revision 20436)
>> +++ ffmpeg-doc.texi ? (working copy)
>> @@ -816,13 +816,16 @@
>> ?('#') character are ignored and are used to provide comments. Check
>> ?the @file{ffpresets} directory in the FFmpeg source tree for examples.
>>
>> -Preset files are specified with the @code{vpre}, @code{apre} and
>> - at code{spre} options. The options specified in a preset file are
>> -applied to the currently selected codec of the same type as the preset
>> -option.
>> +The options specified in a preset file are applied to the currently
>> +selected codec depending on the preset option, which can be
>> + at code{apre} for audio codecs, @code{vpre} for video codecs, and
>> + at code{spre} for subtitle codecs. The @code{fpre} option takes in
>> +the filename of the preset instead of a preset name and can be used
>> +for any kind of codec.
>
> The second sentence is partially contradicting the first one.
>
> Also I believe that the form:
> |the filename of the preset instead of a preset name and can be used
> |for *each* kind of codec
>
> is considered more correct.
>
> I'd prefer to start like in the original:
>
> |Preset files are specified with the @code{vpre}, @code{apre} and
> |@code{spre}, and @code{fpre} options.
>
> Then I'd continue with the fpre option explanation, e.g.:
>
> |The @code{fpre} option takes in input the filename of the preset
> |instead of a preset name and can be used for any kind of codec.
>
> followed by the Xpre options explanation, e.g.:
>
> |With the @code{apre}, @code{vpre}, @code{spre} preset options, the options
> |specified in a preset file are applied to the currently selected
> |codec depending on the preset option, which can be @code{apre} for
> |audio codecs, @code{vpre} for video codecs, and @code{spre} for
> |subtitle codecs.
> |
> |The argument passed to the Xpre options identifies the preset file to
> |use according to the following rules.

New patch attached with your suggestions, and a ':' on "according to
the following rules:"

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fpre_x1.diff
Type: text/x-diff
Size: 1779 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091202/519b6612/attachment.diff>