[FFmpeg-cvslog] r19695 - trunk/libavcodec/twinvq.c

[Diego Biurrun]

On Tue, Aug 25, 2009 at 04:16:37AM +0200, Vitor Sessak wrote:
> Diego Biurrun wrote:
> >On Mon, Aug 24, 2009 at 07:35:47PM +0200, vitor wrote:
> >>Log:
> >>Cosmetics: add some whitespace around operators
> >
> >Hmm, was that in reaction to my comment on your commit?
> 
> Yes.

Well, then I have to say that I hoped you would fix the whole file, not
just the two places I picked out as examples.

> >>--- trunk/libavcodec/twinvq.c	Mon Aug 24 15:43:33 2009 (r19694)
> >>+++ trunk/libavcodec/twinvq.c	Mon Aug 24 19:35:47 2009 (r19695)
> >>@@ -458,7 +458,7 @@ static void add_peak(int period, int wid
> >> 
> >>-    for (j=-width/2; j < (width+1)/2 && shape < shape_end; j++)
> >>+    for (j=-width/2; j < (width + 1)/2 && shape < shape_end; j++)
> >
> >There are still some operators on this line that could benefit from
> >whitespace, especially / and =.
> 
> I try to stick to K&R for most of the things but it goes a little too 
> far on extra whitespaces for my taste. I particularly hate doing
> 
> for (i = 0; i < 10; i++)
> 
> instead of
> 
> for (i=0; i < 10; i++)

That's the good thing about common styles: Nobody gets to be the
privileged person whose style gets picked.  Everybody has to adapt.
Rest assured that there are parts of K&R I dislike as well.  But it's no
use complaining.  After a while you adapt and don't consider it
obnoxious anymore.  Tastes *are* malleable.

So please adapt your style.

Diego