[FFmpeg-cvslog] r18460 - trunk/libavformat/flvdec.c

[Baptiste Coudurier]

On Sun, Apr 12, 2009 at 06:16:11AM +0200, Michael Niedermayer wrote:
> On Sat, Apr 11, 2009 at 09:06:19PM -0700, Baptiste Coudurier wrote:
> > On Sun, Apr 12, 2009 at 06:01:03AM +0200, michael wrote:
> > > Author: michael
> > > Date: Sun Apr 12 06:01:03 2009
> > > New Revision: 18460
> > > 
> > > Log:
> > > Disable metadata reading, yes id like to know what this code is good for
> > > and this is the easiest way to. It would be alot of messy code we can drop
> > > if it is useless.
> > > As a sideeffect this fixes issue977.
> > > 
> > > Modified:
> > >    trunk/libavformat/flvdec.c
> > > 
> > > Modified: trunk/libavformat/flvdec.c
> > > ==============================================================================
> > > --- trunk/libavformat/flvdec.c	Sun Apr 12 05:26:20 2009	(r18459)
> > > +++ trunk/libavformat/flvdec.c	Sun Apr 12 06:01:03 2009	(r18460)
> > > @@ -342,7 +342,7 @@ static int flv_read_packet(AVFormatConte
> > >          if ((flags & 0xf0) == 0x50) /* video info / command frame */
> > >              goto skip;
> > >      } else {
> > > -        if (type == FLV_TAG_TYPE_META && size > 13+1+4)
> > > +        if (type == FLV_TAG_TYPE_META && size > 13+1+4 && 0)
> > >              flv_read_metabody(s, next);
> > >          else /* skip packet */
> > >              av_log(s, AV_LOG_ERROR, "skipping flv packet: type %d, size %d, flags %d\n", type, size, flags);
> > 
> > Humm, but you don't plan to export this in AVMetadata ?
> 
> audiosamplerate, audiocodecid, ... ?
> no, thats no metadata in the AVMetadata sense

Since this is metadata since Adobe declare it as metadata, in what
sense is it metadata, should we introduce AVAdobeMetadata ? ;)

Besides I'd like to have access to this information, how can I ?

Also, a list of keyframes is stored here using a tag flash player
understand which allow seeking before having downloaded the whole
file.

This is definitely something it would be nice to have.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA    
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org