[FFmpeg-cvslog] r18420 - trunk/libavformat/timefilter.c

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Fri, Apr 10, 2009 at 08:15:48PM +0200, Diego Biurrun wrote:
>> On Fri, Apr 10, 2009 at 07:03:01PM +0100, M?ns Rullg?rd wrote:
>> > diego <subversion at mplayerhq.hu> writes:
>> > >
>> > > Log:
>> > > Replace rand() usage by av_lfg_get().
>> > >
>> > > --- trunk/libavformat/timefilter.c	Fri Apr 10 17:16:11 2009	(r18419)
>> > > +++ trunk/libavformat/timefilter.c	Fri Apr 10 19:12:36 2009	(r18420)
>> > > @@ -76,9 +76,12 @@ double ff_timefilter_update(TimeFilter *
>> > >
>> > >  #ifdef TEST
>> > > -#undef rand
>> > > +#include "libavutil/lfg.h"
>> > > +#define LFG_MAX ((1LL << 32) - 1)
>> > 
>> > Why not UINT32_MAX?
>> 
>> I (blindly) followed Reimar's suggestion, I'll change it in a moment.
>
> Hmm, output differs considerably if I make the change you suggest:

It probably has something to do with the signedness.

-- 
M?ns Rullg?rd
mans at mansr.com