[FFmpeg-cvslog] r18306 - trunk/libavformat/flvdec.c

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Fri, Apr 03, 2009 at 06:45:51PM -0700, Baptiste Coudurier wrote:
>> Hi Michael,
>>
>> Michael Niedermayer wrote:
>>> On Thu, Apr 02, 2009 at 06:07:39PM -0700, Baptiste Coudurier wrote:
>>>> Michael Niedermayer wrote:
>>>>> On Thu, Apr 02, 2009 at 02:40:59PM -0700, Baptiste Coudurier wrote:
>>>>>> Michael Niedermayer wrote:
>>>>>>> On Thu, Apr 02, 2009 at 10:30:49AM -0700, Baptiste Coudurier wrote:
>>>>>>>> On 4/2/2009 5:04 AM, Michael Niedermayer wrote:
>>>>>>>>> On Thu, Apr 02, 2009 at 05:52:20AM +0200, bcoudurier wrote:
>>>>>>>>>> Author: bcoudurier
>>>>>>>>>> Date: Thu Apr  2 05:52:19 2009
>>>>>>>>>> New Revision: 18306
>>>>>>>>>>
>>>>>>>>>> Log:
>>>>>>>>>> skip empty data packets in flv, fix input.flv
>>>>>>>>> Could you elaborate on what the problem was?
>>>>>>>> Sure: packet is empty, it only contains header, and no payload,
>>>>>>>> H.264 sequence end packet to be specific (type 2).
>>>>>>>> Flash player reads it correctly.
>>>>>>> I think this change will make a fix to issue271 tricky
>>>>>>> the decoder has to know how much silence to insert and this should
>>>>>>> match the duration of the single empty packet (i think)
>>>>>> Can't this silence be determined by comparing pts difference ?
>>>>> i suspect it can but if the silence is long (and AFAIK this can be) the
>>>>> audio out could be starved by the time the next packet comes in.
>>>>> (I assume here the null packet is muxed earlier but did not verify this)
>>>>>
>>>> Btw, did you notice the <=0 behind av_get_packet ?
>>>> So this actually changed failing on empty packets ;)
>>> fixed that one, is the zero packet skip still needed?
>> Yes, codec is h.264.
>>
>> But I guess it could be changed to this if you feel more comfortable.
> 
> iam curious why is it needed?
> that is what happens without this?
> 

I've pushed h264_type2.flv in incoming.

FFmpeg version SVN-r18329, Copyright (c) 2000-2009 Fabrice Bellard, et al.
  configuration: --enable-gpl --enable-libmp3lame --enable-libfaac
--enable-libgsm --enable-nonfree --enable-libamr-nb --enable-libtheora
--enable-libx264 --enable-libspeex --enable-pthreads --enable-libopenjpeg
  libavutil     50. 3. 0 / 50. 3. 0
  libavcodec    52.23. 0 / 52.23. 0
  libavformat   52.32. 0 / 52.32. 0
  libavdevice   52. 2. 0 / 52. 2. 0
  libswscale     0. 7. 1 /  0. 7. 1
  built on Apr  3 2009 18:09:12, gcc: 4.3.3
[h264 @ 0xa707d20]no frame!

Seems stream 0 codec frame rate differs from container frame rate:
2000.00 (2000/1) -> 66.67 (200/3)
    Last message repeated 93 times
Input #0, flv, from 'h264_type2.flv':
  Duration: 00:44:09.72, start: 0.015000, bitrate: N/A
    Stream #0.0: Video: h264, yuv420p, 66.67 tbr, 1k tbn, 2k tbc
    Stream #0.1: Audio: aac, 48000 Hz, stereo, s16
At least one output file must be specified

"93 times" is weird, and video resolution is not set.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org