[FFmpeg-cvslog] r15348 - in trunk/ffpresets: . libx264-default.ffpreset libx264-fastfirstpass.ffpreset libx264-hq.ffpreset libx264-max.ffpreset libx264-normal.ffpreset

[Mike Melanson]

Michael Niedermayer wrote:
> On Thu, Sep 18, 2008 at 07:12:53PM +0300, Kostya wrote:
>> On Thu, Sep 18, 2008 at 05:41:23PM +0200, Michael Niedermayer wrote:
>>> On Wed, Sep 17, 2008 at 08:16:32PM -0700, Mike Melanson wrote:
>>>>> [...]
>>>>>
>>>>> Is it possible to include comments in a preset file?
>>>> The preset file parser makes no provisions for comments (see 
>>>> ffmpeg.c:opt_preset()). Do you really think Michael is going to let such 
>>>> a user-friendly feature through?
>>> Iam not against supporting comments. -> patch welcome
>> Theoretical but should work
> 
> This patch is ugly
> readng the whole line in would not be that big and ugly, though there may
> be better solutions

This is sort of what I meant when I said you would never let such a 
user-friendly feature through.

-- 
     -Mike Melanson