[FFmpeg-cvslog] r27602 - trunk/libswscale/swscale_template.c

[Michael Niedermayer]

On Sun, Sep 14, 2008 at 02:39:05AM +0200, Luca Barbato wrote:
> Michael Niedermayer wrote:
> > Though i guess we can keep it until these functions are all moved out of
> > the preprocessor template magic and called through normal function pointers.
> 
> I'll try to update the patchset that does that to be applied to the 

:)))


> current code, it should be done in those steps:
> - uniform function signatures
> - get the function pointers in the struct and the logic to fill them 
> inside the template file or directly outside
> - use the function pointers into the swscale function
> - move the function out the template.
> 
> Those 4 steps are a bit big and could be split in about 10 smaller 
> steps. Which is nicer for you for step 2? 

i think the ptr init should be in swscale.c swscale_mmx.c, ...
that is plain C functions in swscale.c and the init of the corresponding
function ptrs as well
for mmx functions they would be in swscale_mmx.c
altivec in swscale_altivec.c
...


> Are you fine with them?

if i replace a few words like 'get' by 'put' ;) yes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080914/e38cc31d/attachment.pgp>