[FFmpeg-cvslog] r15305 - in trunk: Makefile tests/ffmpeg.regression.ref tests/libav.regression.ref tests/regression.sh tests/rotozoom.regression.ref tests/seek.regression.ref

[Michael Niedermayer]

On Sat, Sep 13, 2008 at 10:35:22AM -0700, Mike Melanson wrote:
> Michael Niedermayer wrote:
> > On Fri, Sep 12, 2008 at 09:18:15PM -0700, Mike Melanson wrote:
> >> Mike Melanson wrote:
> >>> michael wrote:
> >>>> Author: michael
> >>>> Date: Sat Sep 13 05:49:54 2008
> >>>> New Revision: 15305
> >>>>
> >>>> Log:
> >>>> Switch regression tests to swscale.
> >>>> Plain C, x86-32 and -64 have been tested and should work, other
> >>>> archs that had asm optmizations in swscale likely will need some fixes
> >>>> to either fallback to C if SWS_BITEXACT is set or make the asm match C.
> >>>> This also disables the PAL8 test as neither swscale or the old scaler
> >>>> really support PAL8 output, imgconvert supported a fixed 666 palette
> >>>> as output and swscale supports fixed 884 and 422.
> >>> Do I need to change anything in FATE?
> >> Judging by the build results so far, I guess I need to update all of the 
> >> build configurations to build with swscale.
> > 
> > You also have to update all tests that involve scaling or colorspace
> > convertion.
> > Also you must pass at least -sws_flags +bitexact to the tests that do.
> 
> Are you sure about this? Because
> 
> ffmpeg -i full9iron-partial.mov -pix_fmt rgb24 -f framecrc -
> 
> and
> 
> ffmpeg -i full9iron-partial.mov -sws_flags +bitexact -pix_fmt rgb24 -f 
> framecrc -
> 
> and
> 
> ffmpeg -sws_flags +bitexact -i full9iron-partial.mov -pix_fmt rgb24 -f 
> framecrc -
> 
> produce identical output. Output that varies from x86_32 to PPC.
> 
> Am I missing something?

sws on ppc does not support bitexact because the flag did not exist when
the ppc code was written and i dont have a ppc so could not test which
parts of the ppc code where bit identical to C.
Its the same reason why the regression tests fail on ppc ATM.

It should pass on ppc when altivec is disabled, if not then the problem
may be elsewhere.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080913/57894448/attachment.pgp>