[FFmpeg-cvslog] r15271 - in trunk/libavcodec: avcodec.h imgconvert.c

[Michael Niedermayer]

On Tue, Sep 09, 2008 at 06:25:40PM +0100, Robert Swain wrote:
> 2008/9/9 Panagiotis Issaris <takis.issaris at uhasselt.be>:
> > Hi,
> >
> > michael wrote:
> >> Author: michael
> >> Date: Mon Sep  8 20:29:08 2008
> >> New Revision: 15271
> >>
> >> Log:
> >> avcodec_find_best_pix_fmt() needs a 64bit mask as there are more than 32 pix_fmts.
> >
> >
> > This is why I tend to agree with Roman. You're doing the exact stuff you
> > would reject from others.
> >
> > You rejected it when _I_ posted this because "your change breaks ABI"
> > and "after we add 27 more pixel formats it would be broken again".
> >
> > http://article.gmane.org/gmane.comp.video.ffmpeg.devel/45519
> 
> I suspect it's less of an issue at the moment as there is a lot of ABI
> change due to the very recent version bump. So I suppose Michael's
> intention is to get it all out of the way. Does that sound about
> right?

this was my intention yes,
takis patch was not ok as it would have required a major version bump
now we do have a bump so the change is ok.

ive also considered to drop this function entirely, so it could later be
added back when needed and when there is more time to design a more
future proof ABI/API. I can do that if people prefer it.

and about "doing the exact stuff you would reject from others." i explicitly
mentioned in my commit that bumped the major version that abi/api breakink
cleanups are welcome now IIRC

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080910/7407401b/attachment.pgp>