[FFmpeg-cvslog] r15193 - in trunk/libavcodec: aac.c lpc.c lpc.h ra288.c

Vitor Sessak vitor1001
Fri Sep 5 00:18:05 CEST 2008


Diego Biurrun wrote:
> On Thu, Sep 04, 2008 at 01:03:14PM +0200, vitor wrote:
>> Log:
>> Avoid duplicating compute_lpc_coefs() function in both the RA288 and AAC decoders.
>>
>> --- trunk/libavcodec/lpc.h	(original)
>> +++ trunk/libavcodec/lpc.h	Thu Sep  4 13:03:14 2008
>> @@ -45,4 +45,58 @@ int ff_lpc_calc_coefs(DSPContext *s,
>>  
>> +#ifdef LPC_USE_DOUBLE
>> +#define LPC_type double
>> +#else
>> +#define LPC_type float
>> +#endif
> 
> I think the convention is to use all-uppercase names for macros.  This
> looks weird.

I'm not against it. Done.

-Vitor




More information about the ffmpeg-cvslog mailing list