[FFmpeg-cvslog] r15741 - trunk/doc/general.texi
diego
subversion
Wed Oct 29 07:48:59 CET 2008
Author: diego
Date: Wed Oct 29 07:48:59 2008
New Revision: 15741
Log:
Add 'make checkheaders' to developer guidelines and patch checklist.
Modified:
trunk/doc/general.texi
Modified: trunk/doc/general.texi
==============================================================================
--- trunk/doc/general.texi (original)
+++ trunk/doc/general.texi Wed Oct 29 07:48:59 2008
@@ -951,6 +951,9 @@ should also be avoided if they don't mak
@item
If you add a new file, give it a proper license header. Do not copy and
paste it from a random place, use an existing file as template.
+ at item
+ If you add a new header or change an existing one, make sure it passes
+ @code{make checkheaders}.
@end enumerate
We think our rules are not too hard. If you have comments, contact us.
@@ -1026,6 +1029,8 @@ do not attach several unrelated patches
@item
Do the regression tests pass with the patch applied?
@item
+ Does @code{make checkheaders} pass with the patch applied?
+ at item
Is the patch a unified diff?
@item
Is the patch against latest FFmpeg SVN?
More information about the ffmpeg-cvslog
mailing list