[FFmpeg-cvslog] r27730 - in trunk/libswscale: swscale.c swscale_internal.h

[Vitor Sessak]

Michael Niedermayer wrote:
> On Sat, Oct 18, 2008 at 11:55:58PM +0200, Vitor Sessak wrote:
>> vitor wrote:
>>> Author: vitor
>>> Date: Wed Oct  8 19:46:22 2008
>>> New Revision: 27730
>>> Log:
>>> Add a new unscaled PAL8 -> RGB converter.
>> 1000l for me for this patch. I tested it, but without noticing that typing 
>> "make" do _not_ rebuild swscale-example. Actually it made a small 
>> regression in {PAL,RGB8,BGR8,RGB4,BGR4}->{RGB32, BGR32}.
>>
>> Three possibilities:
>>
>> 1- Revert it
>> 2- sws_fix10l.diff: fix the actual bug (in rgb2rgb.c)
>> 3- sws_hack.diff: just fix my breakage
> 
> i do not think 2 or 3 fix the code
> the palette is in RGB32 format IIRC so one side of the #ifdef has to be
> wrong. Also the rgb24 would need ifdefs which it does not have, or the
> palette would have to be converted into a differnt byte order or the
> switch case would need to be changed a little

AFAIK, before the palette was either in BGR32 or RGB32 depending on 
alignment. Now I've made everything alignment independent. Also, if I 
understand correctly the code, I think that swscaler uses a slightly 
unusual definition of RGB/BGR.

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sws_fix10l_2.diff
Type: text/x-diff
Size: 2632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081019/8df6f5f7/attachment.diff>