[FFmpeg-cvslog] r12894 - in trunk/libavcodec: aac_ac3_parser.c aac_ac3_parser.h aac_parser.c ac3_parser.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Oct 05, 2008 at 11:19:16PM +0200, Janne Grunau wrote:
>> On Saturday 19 April 2008 03:50:41 michael wrote:
>> > Author: michael
>> > Date: Sat Apr 19 03:50:40 2008
>> > New Revision: 12894
>> >
>> > Log:
>> > Change aac and ac3 parsers to use ff_combine_frame().
>> 
>> This changeset breaks also parsing of AAC in mpeg-ts. The file plays
>> without audio. I can upload a sample but it's just generated by
>> libfaac-enabled ffmpeg with -f mpegts -acodec libfaac.
>
> I can not see any problem with this changeset, rather it appears that the
> new aac decoder does not work with aac in mpeg-ts. And that gcc
> miscompiles aac_parser.c somehow, i did not investigate these further but
> compiling aac_parser.c with -O0 and using libfaad seems to work

The error in aac_parser.c is a strict aliasing violation.  This patch
should fix it.

-- 
M?ns Rullg?rd
mans at mansr.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-aac_parser-fix-strict-aliasing-violation.patch
Type: text/x-patch
Size: 908 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081011/6f4468b2/attachment.bin>