[FFmpeg-cvslog] r13241 - in trunk/libavformat: matroska.h matroskadec.c

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Fri, May 23, 2008 at 12:07:09AM +0200, aurel wrote:
> > Author: aurel
> > Date: Fri May 23 00:07:09 2008
> > New Revision: 13241
> > 
> > Log:
> > demux chapters out of matroska
> > patch by Anton Khirnov  wyskas _at_ gmail _dot_ com
> 
> [...]
> 
> > +                    if(start != AV_NOPTS_VALUE && end != AV_NOPTS_VALUE)
> > +                        res = ff_new_chapter(s, start * AV_TIME_BASE / 1000000000 , end * AV_TIME_BASE / 1000000000, title ? title : "(unnamed)");
> 
> "(unnamed)" is unacceptable, title in AVChapter should be NULL if its unknown!
> 
> The way it is muxers would have to check for "(unnamed)" to be able to mux it
> properly.

Absolutely right ! I don't know what I was thinking about.
Fixed.

Aurel