[FFmpeg-cvslog] r12607 - trunk/libavformat/mov.c

[Michael Niedermayer]

On Thu, Mar 27, 2008 at 02:30:31PM +0100, bcoudurier wrote:
> Author: bcoudurier
> Date: Thu Mar 27 14:30:31 2008
> New Revision: 12607
> 
> Log:
> print essence path in error message
> 
> Modified:
>    trunk/libavformat/mov.c
> 
> Modified: trunk/libavformat/mov.c
> ==============================================================================
> --- trunk/libavformat/mov.c	(original)
> +++ trunk/libavformat/mov.c	Thu Mar 27 14:30:31 2008
> @@ -1259,8 +1259,8 @@ static int mov_read_trak(MOVContext *c, 
>  
>      if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
>          if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
> -            av_log(c->fc, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
> -                   st->index, strerror(errno));
> +            av_log(c->fc, AV_LOG_ERROR, "stream %d, error opening file %s: %s\n",
> +                   st->index, sc->drefs[sc->dref_id-1].path, strerror(errno));

not related to this commit but we cannot call strerror()
The docs say:
 -- Function: char * strerror (int ERRNUM)
[...]
     You should not modify the string returned by `strerror'.  Also, if
     you make subsequent calls to `strerror', the string might be
     overwritten.  (But it's guaranteed that no library function ever
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     calls `strerror' behind your back.)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080327/f6828a9c/attachment.pgp>