[FFmpeg-cvslog] r12595 - trunk/Makefile

[Mike Melanson]

Diego Biurrun wrote:
> On Wed, Mar 26, 2008 at 08:15:14AM -0700, Mike Melanson wrote:
>> diego wrote:
>>> Log:
>>> cosmetics: Rename 'all' target to 'main'.
>>> This is in preparation for common.mak inclusion in the main Makefile.
>> ... oh... was just about the complain about this change breaking one of
>> FATE's assumptions, but I see that it was intentional.
> 
> Ummmmm, are you calling 'make all'?  This is a very brittle way of
> calling the default target.  Just use plain 'make'.

True. The reason I was doing this is because I also wanted to build
tiny_psnr in one command. I have taken that part out since I don't need
the psnr tool right now. It's now just 'make main' which is also brittle
as you say. I guess I should change it to plain 'make' and append '&&
make <something_else>' if I need something else later on.

>> Thanks for exposing some bugs in FATE. Fixing FATE now...
> 
> :)

As trivia, the foregoing didn't technically break FATE. It should have
just made all the tests fail since the binaries didn't get built. But it
forced the FATE script down an as-yet-untested code path (only deployed
a few days ago) that failed horribly. I thank you for the test case. :)

-- 
	-Mike Melanson