[FFmpeg-cvslog] r12593 - trunk/libavcodec/ac3dec.c

[Michael Niedermayer]

On Wed, Mar 26, 2008 at 01:58:48AM +0200, Uoti Urpala wrote:
> On Tue, 2008-03-25 at 19:38 -0400, Justin Ruggles wrote:
> > jbr wrote:
> > > @@ -191,6 +194,7 @@ typedef struct {
> > >      GetBitContext gbc;                      ///< bitstream reader
> > >      AVRandomState dith_state;               ///< for dither generation
> > >      AVCodecContext *avctx;                  ///< parent context
> > > +    uint8_t input_buffer[AC3_MAX_FRAME_SIZE];   ///< temp buffer to prevent overread
> > >  } AC3DecodeContext;
> > 
> > Right after I applied this, it occurred to me that it might be better to
> > allocate this with av_malloc() at decoder init depending on
> > error_resiliance.  Does that sound like a good idea?

yes


> 
> I haven't looked at the specific code in this case, 

i see

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080326/38ad5d6e/attachment.pgp>