[FFmpeg-cvslog] r12512 - trunk/libavcodec/i386/dsputil_mmx.c

Michael Niedermayer michaelni
Fri Mar 21 00:55:48 CET 2008


On Fri, Mar 21, 2008 at 12:16:53AM +0200, Uoti Urpala wrote:
> On Thu, 2008-03-20 at 14:52 -0700, Mike Melanson wrote:
> > michael wrote:
> > > Log:
> > > Hardcode register to prevent aparent miscompilation.
> > > Fixes regression tests with gcc 2.95.
> > 
> > Awesome. FATE thanks you. :)
> 
> Not so awesome for people with working compilers. The change makes the
> code worse for the sake of working around bugs in an obsolete compiler.

#define uoti_worse_code supports_gcc2_95()

Anyway, the "worse" code should be faster, as it uses a register where the old
could use memory. Also the gcc 2.95 bug helped finding a unused temp variable
(see previous commit) removing that surely improved speed.

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080321/cbd731e2/attachment.pgp>



More information about the ffmpeg-cvslog mailing list