[FFmpeg-cvslog] r12362 - in trunk: common.mak configure libavcodec/Makefile libavdevice/Makefile libavfilter/Makefile libavformat/Makefile libavutil/Makefile libpostproc/Makefile

[Diego Biurrun]

On Wed, Mar 12, 2008 at 08:23:41PM +0200, Uoti Urpala wrote:
> On Wed, 2008-03-12 at 16:23 +0000, M?ns Rullg?rd wrote:
> > Uoti Urpala wrote:
> > > On Fri, 2008-03-07 at 20:27 +0100, mru wrote:
> > >> -    echo "SPPVERSION=$LIBPOSTPROC_VERSION" >> config.mak
> > >
> > > configure still contains a reference to SPPVERSION elsewhere:
> > >
> > >     darwin)
> > >         disable need_memalign
> > >         SHFLAGS='-dynamiclib -Wl,-single_module -Wl,-install_name,$(SHLIBDIR)/$(SLIBNAME),-current_version,$(SPPVERSION),-compatibility_version,$(SPPVERSION) -Wl,-read_only_relocs,suppress'
> > 
> > WTF is that doing there?
> 
> Someone randomly chose a variable to use for 'library version'?

Probably.  I just discussed this with Alexander Strange on IRC:

20:06 <@DonDiego> a line in configure is wrong
20:06 <@DonDiego> the one that references SPPVERSION
20:06 <@DonDiego> configure:1203:
20:06 <@DonDiego> SHFLAGS='-dynamiclib -Wl,-single_module -Wl,-install_name,$(SHLIBDIR)/$(SLIBNAME),-current_version,$(SPPVERSION),-compatibility_version,$(SPPVERSION) -Wl,-read_only_relocs,suppress'
20:07 <@DonDiego> so what is this current_version and compatibility_version stuff anyway?
20:07 < astrange> current version is the implementation version, compatibility version is the API version
20:08 < astrange> so if you change the compatibility version binaries with an older one can't load it

So this should be replaced by a saner value, I've chosen LIBVERSION and
LIBMAJOR, Alexander will test it for me in a moment.

Diego