[FFmpeg-cvslog] r13660 - in trunk/libavcodec: avcodec.h libx264.c utils.c

[Michael Niedermayer]

On Fri, Jun 06, 2008 at 10:30:29AM +0200, Aurelien Jacobs wrote:
> On Thu,  5 Jun 2008 03:57:36 +0200 (CEST)
> bcoudurier <subversion at mplayerhq.hu> wrote:
> 
> > Author: bcoudurier
> > Date: Thu Jun  5 03:57:35 2008
> > New Revision: 13660
> > 
> > Log:
> > add esa/dia compat me options and new tesa for libx264
> > 
> > [...]
> > 
> > Modified: trunk/libavcodec/libx264.c
> > ==============================================================================
> > --- trunk/libavcodec/libx264.c	(original)
> > +++ trunk/libavcodec/libx264.c	Thu Jun  5 03:57:35 2008
> > @@ -220,6 +220,8 @@ X264_init(AVCodecContext *avctx)
> >          x4->params.analyse.i_me_method = X264_ME_UMH;
> >      else if(avctx->me_method == ME_FULL)
> >          x4->params.analyse.i_me_method = X264_ME_ESA;
> > +    else if(avctx->me_method == ME_TESA)
> > +        x4->params.analyse.i_me_method = X264_ME_TESA;
> >      else x4->params.analyse.i_me_method = X264_ME_HEX;
> >  
> >      x4->params.analyse.i_me_range = avctx->me_range;
> 
> This don't compile with older x264 versions (ie. the one shipped
> with various current distro).
> I don't remember what's the politics about supporting older x264
> or not. But adding a stricter check in configure to ensure recent
> x264 is present shouldn't be hard. 

> And a simple #ifdef around the
> above code would be enough to support older versions.

Yes, if the maintainer wants to maintain that ...
Ive seen where things like that can lead to though, the lavc in mplayer
code more precissely, it had something like 500 ifdefs, it did work with
any lavc version though ...
well that where the times when arpi leaded mplayer, now most ifdefs are
gone but it will not work with old lavc anymore ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080606/752cb751/attachment.pgp>