[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[The Wanderer]

Michael Niedermayer wrote:

> On Thu, Jul 31, 2008 at 07:47:05PM +0200, Michael Niedermayer wrote:
> 
>> On Thu, Jul 31, 2008 at 01:11:14PM -0400, compn wrote:

>>> is this policy documented somewhere?
>> 
>> it has not even been discussed or agreed upon yet ...
>> 
>> Besides maybe we can make the converter independant of avcodec.h
>> Which seems better either way ...
> 
> and just to repeat my view on the headers inclusion IMHO headers
> should NOT include other headers, this nicely avoids such problems
> ...

It also leads to the case where including one header leads to needing to
include another header, which might in turn need another header, et
cetera. If a header needs something then it should provide that thing,
either by defining it directly or (more practically) by including
another header which already defines it. A header which fails to do so
is, IMO, broken.

In this case, audioconvert.h needs the SampleFormat enum, so it should
provide that. If that requires including avformat.h in audioconvert.h,
then that is what should happen; if headers should not include other
headers unless documented to do so, then the answer would be to so
document it rather than to break the header again.

-- 
       The Wanderer appears to be surprisingly argumentative today

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.