[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Thu, Jul 31, 2008 at 01:11:14PM -0400, compn wrote:
> On Thu, 31 Jul 2008 16:32:20 +0200, Aurelien Jacobs wrote:
> >Not only unnecessary, but even bad.
> >The usage here is that every file must include every headers that it
> >requires directly. You should not rely on one header including another
> >(except when it's explicitely documented so, such as inttypes.h
> >including stdint.h).
> >So here you should add back the avcodec.h include.
> 
> is this policy documented somewhere?

it has not even been discussed or agreed upon yet ...

Besides maybe we can make the converter independant of avcodec.h
Which seems better either way ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080731/22889945/attachment.pgp>