[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Måns Rullgård]

pross at xvid.org wrote:
> On Thu, Jul 31, 2008 at 03:35:05PM +0200, Benoit Fouet wrote:
>> pross wrote:
>> > Modified: trunk/libavcodec/audioconvert.c
>> > ==============================================================================
>> > --- trunk/libavcodec/audioconvert.c	(original)
>> > +++ trunk/libavcodec/audioconvert.c	Thu Jul 31 14:55:06 2008
>> > @@ -25,7 +25,49 @@
>> >   * @author Michael Niedermayer <michaelni at gmx.at>
>> >   */
>> >
>> > -#include "avcodec.h"
>> >
>>
>> why did you remove this one ?
>> isn't it needed by the file ?
>
> avcodec.h is provided by audioconvert.h.
>
> Indeed, this change was unnecessary and could have been comitted later,
> seperately.  I'll avoid such changes in future...

It should not be committed at all.  Files should #include all headers they
explicitly depend on.  The only exceptions to this rule are common.h and
internal.h.

Please revert this.

-- 
M?ns Rullg?rd
mans at mansr.com